Skip to content

DOCSP-47961 v2.1 release #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 12, 2025
Merged

Conversation

lindseymoore
Copy link
Collaborator

@lindseymoore lindseymoore commented Mar 7, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-47961
Staging -

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Mar 7, 2025

Deploy Preview for docs-golang ready!

Name Link
🔨 Latest commit 07b81d5
🔍 Latest deploy log https://app.netlify.com/sites/docs-golang/deploys/67d07e9cbbc9ef000890c598
😎 Deploy Preview https://deploy-preview-465--docs-golang.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@rachel-mack rachel-mack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lindseymoore lindseymoore requested review from a team and qingyang-hu and removed request for a team and qingyang-hu March 10, 2025 14:01
Copy link

@jtazin jtazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two comments, and one optional one outside the scope of this work

@lindseymoore lindseymoore requested a review from jtazin March 10, 2025 18:22
@lindseymoore lindseymoore requested a review from jtazin March 11, 2025 17:39
Comment on lines 48 to 50
- Adds the new `Client.BulkWrite <{+api+}/mongo#Client.BulkWrite>`__ method
to make performing many insert, update, and delete operations on multiple databases and
collections in one request more efficient.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending on how you interpret the "more efficient" part it could be slightly inaccurate. How about one of these variants?

Adds the new Client.BulkWrite <{+api+}/mongo#Client.BulkWrite>__ method to provide clients the ability to perform many insert, update, and delete operations on multiple databases and collections in one request.

or

Introduces the new Client.BulkWrite <{+api+}/mongo#Client.BulkWrite>__, enabling clients to perform multiple insert, update, and delete operations across databases and collections in a single request.

Copy link
Collaborator Author

@lindseymoore lindseymoore Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the second one, thanks! Also added 'Introduces' to second bullet

@lindseymoore lindseymoore requested a review from jtazin March 11, 2025 18:22
Copy link

@jtazin jtazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, Lindsey

@lindseymoore lindseymoore merged commit 4162ee4 into mongodb:master Mar 12, 2025
5 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 12, 2025
* DOCSP-47961 v2.1 release

* edits

* weird vale error

* JT edits

* consistency edits

* edits

(cherry picked from commit 4162ee4)
lindseymoore added a commit that referenced this pull request Mar 12, 2025
* DOCSP-47961 v2.1 release

* edits

* weird vale error

* JT edits

* consistency edits

* edits

(cherry picked from commit 4162ee4)

Co-authored-by: lindseymoore <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants