-
Notifications
You must be signed in to change notification settings - Fork 34
DOCSP-47961 v2.1 release #465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-golang ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two comments, and one optional one outside the scope of this work
source/whats-new.txt
Outdated
- Adds the new `Client.BulkWrite <{+api+}/mongo#Client.BulkWrite>`__ method | ||
to make performing many insert, update, and delete operations on multiple databases and | ||
collections in one request more efficient. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depending on how you interpret the "more efficient" part it could be slightly inaccurate. How about one of these variants?
Adds the new
Client.BulkWrite <{+api+}/mongo#Client.BulkWrite>
__ method to provide clients the ability to perform many insert, update, and delete operations on multiple databases and collections in one request.
or
Introduces the new
Client.BulkWrite <{+api+}/mongo#Client.BulkWrite>
__, enabling clients to perform multiple insert, update, and delete operations across databases and collections in a single request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the second one, thanks! Also added 'Introduces' to second bullet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks, Lindsey
* DOCSP-47961 v2.1 release * edits * weird vale error * JT edits * consistency edits * edits (cherry picked from commit 4162ee4)
* DOCSP-47961 v2.1 release * edits * weird vale error * JT edits * consistency edits * edits (cherry picked from commit 4162ee4) Co-authored-by: lindseymoore <[email protected]>
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-47961
Staging -
Self-Review Checklist